Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow zsh users to have the nomatch option set #1938

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Allow zsh users to have the nomatch option set #1938

merged 1 commit into from
Nov 8, 2018

Conversation

agross
Copy link
Contributor

@agross agross commented Nov 7, 2018 •
edited by ljharb
Loading

Fixes #1937

@agross agross changed the title [WIP] Allow zsh users to have the nomatch option set Allow zsh users to have the nomatch option set Nov 8, 2018
@agross
Copy link
Contributor Author

agross commented Nov 8, 2018

@ljharb Please review my changes.

ljharb
ljharb approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to need to do some local testing on this, but thanks - this makes things much clearer.

Can you confirm which versions of zsh local_options works with?

@ljharb ljharb merged commit 17586b9 into nvm-sh:master Nov 8, 2018
@agross
Copy link
Contributor Author

agross commented Nov 9, 2018

Can you confirm which versions of zsh local_options works with?

I do not know for sure. The changelog mentions setopt localoptions once for version 3.0.6 in relation to something else that uses it. The earliest tagged version (3.1.5) is from 1999. I think we can assume that it is available everywhere.

@ljharb
Copy link
Member

ljharb commented Nov 9, 2018

I'm comfortable with 1999 :-) thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
shell: zsh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agross @ljharb