Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick lsp_reference from multpile clients #2342

Closed
wants to merge 4 commits into from

Conversation

hunterliao29
Copy link

@hunterliao29 hunterliao29 commented Jan 23, 2023

Description

When one buffer is attached to multiple lsp clients, current implementation will only allow one client's result be shown.
This cause issues when two client return different set of references.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration

  • Test A: Create an angular project using
ng new test
nvim test/src/app/app.component.ts

Telescope lsp_references on title(line 9)

Configuration:

  • Neovim version (nvim --version): 0.8.2 and master
  • Operating system and version: macOS 13.1

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@pidgeon777
Copy link

Do you think the same could be done for LSP definitions and implementations?

@tjdevries
Copy link
Member

This is a good idea -- I think maybe we should do this as well for definitions and implementations. Do you want to do that or would you prefer if I did that in a separate PR?

@pidgeon777
Copy link

Do you want to do that or would you prefer if I did that in a separate PR?

@tjdevries It would be great I think if you could proceed with it 👍.

@eslam-allam
Copy link

perhaps this should be extended to other lsp functionality as well e.g. lsp_document_symbols ?

@pidgeon777
Copy link

perhaps this should be extended to other lsp functionality as well e.g. lsp_document_symbols ?

Yes, also that, preventing any duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants