Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): a way to recognise plugins managed by extensions as dependencies #492

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Jul 29, 2024

Closes #365

This provides a function that extensions can invoke to install or remove a luarocks stub, in order to trick luarocks into thinking a luarocks package is installed.

That way, plugins managed by extensions like rocks-git or rocks-dev can be recognised by luarocks as being installed, if other luarocks packages depends on them.

TODO:

  • Use the API in rocks-git and test it manually.
  • Use the API in rocks-dev and test it manually.

Requires the following experimental feature to be enabled:

vim.g.rocks_nvim = {
  -- ...
  experimental_features = {
    "ext_module_dependency_stubs",
  },
}

and up-to-date rocks.nvim extensions.

@mrcjkb
Copy link
Member Author

mrcjkb commented Aug 2, 2024

Done and tested.

We could later add the ability to add dependencies to the stub template; see #388

@mrcjkb
Copy link
Member Author

mrcjkb commented Aug 30, 2024

come to think of it, we should probably put this behind a config flag and make it an experimental feature, with an announcement calling for testers.

@mrcjkb mrcjkb enabled auto-merge (squash) September 1, 2024 01:39
@mrcjkb mrcjkb disabled auto-merge September 1, 2024 13:40
@mrcjkb mrcjkb changed the title feat(api): a way to recognise plugins managed by extensions as dependencies feat(experimental): a way to recognise plugins managed by extensions as dependencies Sep 1, 2024
doc/rocks.txt Outdated Show resolved Hide resolved
@mrcjkb mrcjkb force-pushed the dummy-rocks branch 2 times, most recently from 1915eda to a7fffe1 Compare September 1, 2024 18:24
@mrcjkb
Copy link
Member Author

mrcjkb commented Sep 2, 2024

Self-merging, as this is now experimental and disabled by default.

@mrcjkb mrcjkb merged commit 79123d6 into master Sep 2, 2024
9 checks passed
@mrcjkb mrcjkb deleted the dummy-rocks branch September 2, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] plugins installed with rocks-git, rocks-dev, ... should be recognized as dependencies
1 participant