Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: progress bar #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: progress bar #105

wants to merge 1 commit into from

Conversation

ricardogobbosouza
Copy link
Contributor

Resolve #52

@codecov-commenter
Copy link

Codecov Report

Merging #105 into dev will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #105      +/-   ##
==========================================
+ Coverage   90.90%   91.07%   +0.16%     
==========================================
  Files           1        1              
  Lines          55       56       +1     
  Branches       30       31       +1     
==========================================
+ Hits           50       51       +1     
  Misses          5        5              
Impacted Files Coverage Δ
lib/module.js 91.07% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc3e78e...e335e7c. Read the comment docs.

@pi0 pi0 added the pending label Jun 5, 2020
@pi0
Copy link
Member

pi0 commented Jun 5, 2020

Hi @ricardogobbosouza. Thanks for PR ❤️ I added a pending label as there is an active discussion nuxt-communiry/axios-module#247 and the best way we should integrate with progress-bar. We might add a shared utility to nuxt for easier integration.

@pi0 pi0 changed the base branch from dev to master September 1, 2020 12:50
@mbergen
Copy link

mbergen commented May 18, 2022

Is this still being discussed?

@pi0
Copy link
Member

pi0 commented May 20, 2022

Hi dear @mbergen. Yes, we are discussing it for Nuxt 3 API to be considered as a built-in API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Nuxt Progress Bar
4 participants