Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): pass analyze options through to nitro #6871

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Somehow we dropped this configuration out. We can hard code defaults in as if user is using webpack builder we can't assume options are compatible. User can override with nitro.analyze directly.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Aug 23, 2022
@danielroe danielroe requested a review from pi0 August 23, 2022 13:48
@danielroe danielroe self-assigned this Aug 23, 2022
@netlify
Copy link

netlify bot commented Aug 23, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit dae818e
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6304da9b5bee570008f825c6
😎 Deploy Preview https://deploy-preview-6871--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0 pi0 merged commit 45f39be into main Aug 23, 2022
@pi0 pi0 deleted the fix/nitro-analyze branch August 23, 2022 13:54
@pi0 pi0 mentioned this pull request Aug 26, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants