Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): handle relative baseURL #468

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix(dev): handle relative baseURL #468

merged 1 commit into from
Sep 5, 2024

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Sep 5, 2024

πŸ”— Linked issue

related: nuxt/nuxt#28474

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When passing a relative app.baseURL, this should not affect how the server is started. This applies the same fix in Nuxt runtimeConfig:

https://github.com/nuxt/nuxt/blob/d1c40328fe959f05ae77cc66311c40d5f151a109/packages/schema/src/config/nitro.ts#L18-L20

@danielroe danielroe merged commit 0aad36b into main Sep 5, 2024
2 checks passed
@danielroe danielroe deleted the fix/relative-base-url branch September 5, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant