fix: handle spaces in path at repo initialization #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
reviewed
Nov 28, 2023
Ettapp
force-pushed
the
fix/repository-directory-name-containing-spaces
branch
from
4724f6b
to
0bbef1e
Compare
|
Not sure I did the right thing by force-pushing the suggested change, but here it is, thanks for the advice ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the issue happening when one run
nuxi init .in a directory whose path contains spaces.It just surround the path variable with in double quote in the string literal.
(This is my first public PR, I've looked for a contribution guide but did not find it... If there is anything wrong with the way I made it feel free to discard it and fix the concerned line directly, I'll learn by watching 😉 )