Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analyze): don't override analyze options #259

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix(analyze): don't override analyze options #259

merged 1 commit into from
Oct 23, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Oct 22, 2023

This should be backwards compatible as we just checking truthiness of this option in previous versions of Nuxt.

Once nuxt/nuxt#23856 is merged, we will then be able to respect user-set defaults in nuxt.config.

resolves #238

@danielroe danielroe added the bug Something isn't working label Oct 22, 2023
@danielroe danielroe requested a review from pi0 October 22, 2023 06:20
@danielroe danielroe self-assigned this Oct 22, 2023
@pi0 pi0 changed the title fix: don't override preexisting analyze options fix(analyze): don't override analyze options Oct 23, 2023
@danielroe danielroe merged commit a7d5461 into main Oct 23, 2023
2 checks passed
@danielroe danielroe deleted the fix/analyze branch October 23, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

analyze ignores build.analyze.template option
2 participants