Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mod-search): filter mod search by compatible nuxt version #134

Merged
merged 8 commits into from
Sep 18, 2023

Conversation

rohrig
Copy link
Contributor

@rohrig rohrig commented Aug 31, 2023

Closes #115

❓ Type of change
✨ New feature (a non-breaking change that adds functionality)

📚 Description
This PR introduces a version compatibility filter for the module search function.

@rohrig rohrig force-pushed the feat/filterModSearchByVersion branch from c1ded27 to 70744a8 Compare August 31, 2023 20:48
Copy link
Member

atinux commented Sep 5, 2023

Thank you!

Wondering if we should leverage https://github.com/nuxt/nuxt/blob/5390ca43212656b7f169153024f9b19bcd10ec25/packages/kit/src/compatibility.ts#L12 or not 🤔

It would be nice to automatically detect the current Nuxt version installed in the project to give as as default if ctx.args.nuxtVersion is not defined, wdyt @rohrig ?

@rohrig
Copy link
Contributor Author

rohrig commented Sep 6, 2023

Thank you!

Wondering if we should leverage https://github.com/nuxt/nuxt/blob/5390ca43212656b7f169153024f9b19bcd10ec25/packages/kit/src/compatibility.ts#L12 or not 🤔

It would be nice to automatically detect the current Nuxt version installed in the project to give as as default if ctx.args.nuxtVersion is not defined, wdyt @rohrig ?

Hi @atinux ,

I think that's ideal. It was my initial goal but I wasn't able to figure it out and got distracted 😄

I'd be happy to implement it if you give me some pointers on how to do it.

I attempted to do this but I ran into the error that Nuxt is not available:
image

image

Copy link
Member

atinux commented Sep 11, 2023

Well then maybe we don't need to use Kit for now :)

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have made few refactors + auto detected nuxt version

@pi0 pi0 merged commit 576828b into nuxt:main Sep 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuxi module search should filter incompatible module with current Nuxt version
3 participants