Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty i18n options not loading vue-i18n config file #3093

Conversation

BobbieGoede
Copy link
Collaborator

@BobbieGoede BobbieGoede commented Sep 10, 2024

๐Ÿ”— Linked issue

โ“ Type of change

  • ๐Ÿ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • โœจ New feature (a non-breaking change that adds functionality)
  • ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

This regression was picked up in the @nuxt/test-utils examples, see nuxt/test-utils#930. Regression was introduced by #3054, hopefully this is not a common scenario (no options, but relying on i18n.config) and if it is I hope we caught it early ๐Ÿ™

The edge case is pretty specific, if no options are passed to the module, whether inline or using the i18n key, the default i18n.config file was not loaded.

Will backport this to v8 after merging!

๐Ÿ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede removed the request for review from kazupon September 10, 2024 20:50
@BobbieGoede BobbieGoede merged commit c720b6d into nuxt-modules:main Sep 10, 2024
8 checks passed
@BobbieGoede BobbieGoede deleted the fix/empty-options-vue-i18n-regression branch September 10, 2024 21:05
BobbieGoede added a commit to BobbieGoede/i18n that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant