feat/git changed paths only #349
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimbatm
reviewed
Jul 9, 2024
| case Auto: | ||
| return Detect(root, pathsCh) | ||
| return Detect(root, gitAllFiles, pathsCh) | ||
| case Filesystem: |
There was a problem hiding this comment.
Would it make sense to emit a warning if gitAllFiles is true in this case?
| } | ||
| // we only want to emit files that have changed when compared with the index | ||
| // mod time comparison is done with EPOCH (second) precision as per the POSIX spec | ||
| return entry.ModifiedAt.Truncate(time.Second) != info.ModTime().Truncate(time.Second) |
There was a problem hiding this comment.
Is the entry.ModifiedAt coming from the git commit?
brianmcgee
force-pushed
the
feat/git-changed-paths-only
branch
from
1c868e1
to
22718bc
Compare
If the modified time has not changed when compared with the git index we do not emit the file for processing. This allows users to introduce treefmt to a repository without suffering an initial large formatting commit. Instead, files can be formatted incrementally as they are changed. Closes #311 Signed-off-by: Brian McGee <brian@bmcgee.ie>
brianmcgee
force-pushed
the
feat/git-changed-paths-only
branch
2 times, most recently
from
185b47f
to
46014f8
Compare
Signed-off-by: Brian McGee <brian@bmcgee.ie>
brianmcgee
force-pushed
the
feat/git-changed-paths-only
branch
from
46014f8
to
9cfe7db
Compare
Signed-off-by: Brian McGee <brian@bmcgee.ie>
brianmcgee
force-pushed
the
feat/git-changed-paths-only
branch
from
56e15f1
to
352b6e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the modified time has not changed when compared with the git index we do not emit the file for processing.
This allows users to introduce treefmt to a repository without suffering an initial large formatting commit.
Instead, files can be formatted incrementally as they are changed.
TODO
Closes #311