Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: --no-cache #344

Merged
merged 4 commits into from
Jul 5, 2024
Merged

fix: --no-cache #344

merged 4 commits into from
Jul 5, 2024

Conversation

brianmcgee
Copy link
Member

@brianmcgee brianmcgee commented Jul 5, 2024 •
edited
Loading

Separates out the logic for detecting changes from the logic for updating the cache, fixing the case where both --fail-on-change and --no-cache are enabled.

Closes #343

Signed-off-by: Brian McGee brian@bmcgee.ie

@brianmcgee
fix: --no-cache
33a7bba 
Separates out the logic
for detecting changes from the logic for updating the cache, fixing the case where both `--fail-on-change` and `--no-cache`
are enabled.

Closes #343

Signed-off-by: Brian McGee <brian@bmcgee.ie>
@brianmcgee brianmcgee requested review from zimbatm and flokli July 5, 2024 15:12
@brianmcgee brianmcgee mentioned this pull request Jul 5, 2024
Closed
zimbatm
zimbatm approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get to test it yet but it looks ok

cli/format.go Outdated Show resolved Hide resolved
cli/format.go Outdated Show resolved Hide resolved
brianmcgee and others added 2 commits July 5, 2024 18:26
@brianmcgee @zimbatm
Update cli/format.go
b2000dc 
Co-authored-by: Jonas Chevalier <zimbatm@zimbatm.com>
@brianmcgee @zimbatm
Update cli/format.go
6776b9f 
Co-authored-by: Jonas Chevalier <zimbatm@zimbatm.com>
@brianmcgee @zimbatm
fix: --no-cache
42decbf 
Separates out the logic for detecting changes from the logic for updating the cache, fixing the case where both `--fail-on-change` and `--no-cache` are enabled.

Signed-off-by: Brian McGee <brian@bmcgee.ie>
Co-authored-by: Jonas Chevalier <zimbatm@zimbatm.com>
Signed-off-by: Brian McGee <brian@bmcgee.ie>
@brianmcgee
Copy link
Member Author

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 5, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request #344 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@brianmcgee brianmcgee merged commit 23e563b into main Jul 5, 2024
20 checks passed
@brianmcgee brianmcgee deleted the fix/no-cache branch July 5, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

You cannot combine: --no-cache --fail-on-change
2 participants
@brianmcgee @zimbatm