Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow .gitignore directives #24

Closed
basile-henry opened this issue Jan 27, 2021 · 2 comments · Fixed by #25
Closed

Follow .gitignore directives #24

basile-henry opened this issue Jan 27, 2021 · 2 comments · Fixed by #25
Labels
enhancement New feature or request

Comments

@basile-henry
Copy link
Contributor

Avoid formatting files and directories that are gitignored. The ignore crate looks relevant for this.
@basile-henry basile-henry added the enhancement New feature or request label Jan 27, 2021
@zimbatm
Copy link
Member

zimbatm commented Jan 27, 2021

That's what we are using in nixpkgs-fmt and it works well enough.

@Rizary
Copy link
Contributor

Rizary commented Jan 27, 2021

Some people still prefer the cli (as you see in nixpkgs-fmt's issue), but I agree we should have this ignore features. Moreover, it should align with the #13 feature and not contradict each other.

basile-henry added a commit that referenced this issue Jan 28, 2021
@basile-henry
Use ignore for better control over globbing
58074d9 
resolves #13: Includes and excludes
resolves #24: Follows .gitgnore directives
@basile-henry basile-henry mentioned this issue Jan 28, 2021
Merged
brianmcgee added a commit that referenced this issue May 13, 2024
@brianmcgee
fix: duplicate processing in ordered formatters (#24)
15db7f4 
Fixes a bug with formatters processing paths out of order.

Signed-off-by: Brian McGee <brian@bmcgee.ie>

Reviewed-on: https://git.numtide.com/numtide/treefmt/pulls/24
Co-authored-by: Brian McGee <brian@bmcgee.ie>
Co-committed-by: Brian McGee <brian@bmcgee.ie>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ignore for better control over globbing numtide/treefmt
3 participants
@zimbatm @basile-henry @Rizary