Added hint for ndarray.__new__

[bedder]

numpy.ndarray.__new__ previously did not have any type definitions, meaning that code that directly instantiates np.ndarray instances would be flagged by mypy as having unexpected arguments.

I think this should fix the issue - at the very least this change removes what I consider to be invalid warnings on my codebase - although I'm unsure about whether the type for the buffer is correct.

[shoyer]

There seems to be a bigger issue about defining buffer types (python/typing#593), but this seems like a good start.

Thanks @bedder !

[bedder]

Thanks to everyone working on this project - it's a really useful addition to numpy!

At my work we've ended up creating a public fork of this project, and have slowly been adding type hints for more of the numpy library. If it would be useful to yourselves (and not too spammy), we'd be happy to raise more PRs for the additions we've been using internally.

[shoyer]

Yes, we would be very happy to review pull requests!

…

On Mon, Jul 8, 2019 at 2:25 AM Matthew Bedder ***@***.***> wrote: Thanks to everyone working on this project - it's a really useful addition to numpy! At my work we've ended up creating a public fork of this project <https://github.com/Prowler-io/numpy-stubs>, and have slowly been adding type hints for more of the numpy library. If it would be useful to yourselves (and not too spammy), we'd be happy to raise more PRs for the additions we've been using internally. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#29?email_source=notifications&email_token=AAJJFVVNZZQ3N64UIAPPR7LP6MBW7A5CNFSM4HVVJA32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZMQJCQ#issuecomment-509150346>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJJFVSR3S5NEX7BP4BSMADP6MBW7ANCNFSM4HVVJA3Q> .

[shoyer]

Feel free to ping me directly for reviews -- this repo has been a little quiet recently (and GitHub's notifications UI for maintainers is a bit of a mess) so I have been missing some activity here.

…

On Mon, Jul 8, 2019 at 8:34 AM Stephan Hoyer ***@***.***> wrote: Yes, we would be very happy to review pull requests! On Mon, Jul 8, 2019 at 2:25 AM Matthew Bedder ***@***.***> wrote: > Thanks to everyone working on this project - it's a really useful > addition to numpy! > > At my work we've ended up creating a public fork of this project > <https://github.com/Prowler-io/numpy-stubs>, and have slowly been adding > type hints for more of the numpy library. If it would be useful to > yourselves (and not too spammy), we'd be happy to raise more PRs for the > additions we've been using internally. > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > <#29?email_source=notifications&email_token=AAJJFVVNZZQ3N64UIAPPR7LP6MBW7A5CNFSM4HVVJA32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZMQJCQ#issuecomment-509150346>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAJJFVSR3S5NEX7BP4BSMADP6MBW7ANCNFSM4HVVJA3Q> > . >