Switch from entrypoints to importlib.metadata #792
+49
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
==========================================
- Coverage 91.54% 91.32% -0.23%
==========================================
Files 17 17
Lines 1621 1636 +15
==========================================
+ Hits 1484 1494 +10
- Misses 137 142 +5 |
MSeal
approved these changes
Aug 20, 2024
Since the minimum Python version supported now directly supports querying entry points using the standard library, write a wrapper around to support both upstream APIs, and make use of it, rather than the external entrypoints package.
s-t-e-v-e-n-k
force-pushed
the
drop-use-of-entrypoints
branch
from
d100d5f
to
b41914f
Compare
Borda
reviewed
Sep 18, 2024
| Since the importlib.metadata entry points API is very simple in 3.8 and | ||
| more complete in 3.10+, we need to support both. This function can be | ||
| removed when 3.10 is the minimum supported version, and replaced | ||
| with entry_points(group=group). |
There was a problem hiding this comment.
Suggested change
| with entry_points(group=group). | |
| with ``entry_points(group=group)``. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the minimum Python version supported now directly supports querying entry points using the standard library, write a wrapper around to support both upstream APIs, and make use of it, rather than the external entrypoints package.