Only show copy button if there is text to copy #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenRussert
added
work in progress 👷♂️
reviewable ✔️
and removed
work in progress 👷♂️
labels
lgeiger
approved these changes
Aug 14, 2017
There was a problem hiding this comment.
This is so much cleaner now, thanks!
I also experienced strange issues with the expand button but I think the underlying issue is in Atom core: atom/atom#15282
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the open items in #796. If there is no
innerTextto copy the copy icon should not show in the result view toolbar.Since there won't always be an export button anymore, i've also moved the execution count display to a close button tooltip.
I tagged as wip because this seems to break the expand button, but wanted to open anyway since im running out of weekend! Free emoji waiting for you if you find the bug.Edit: I dont think this pr has the issue, but I am not sure the expand button is working correctly (possibly just on my machine and possibly only as of atom 1.19, I have the same issue on hydrogen v1.19 release)New tooltip:
