Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty display message of output area #871

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

lgeiger
Copy link
Member

@lgeiger lgeiger commented Jun 14, 2017

This fixes a few small issues introduced in #866:

  • Move empty message from history to output-area component. Otherwise the empty message would be displayed in the watch sidebar as well. This would look a bit odd since the panel actually isn't empty.
  • Move the message into a <li> element to fix centering if the output area is wider than the message. This is the way recommended by the Atom style guide

@lgeiger lgeiger added the bug 🐛 For unexpected issues label Jun 14, 2017
Copy link
Member

@BenRussert BenRussert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks!

@BenRussert BenRussert merged commit d5ec68a into nteract:master Jun 14, 2017
@lgeiger lgeiger deleted the fix-empty branch June 14, 2017 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 For unexpected issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants