Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep ZMQKernel class if restarted #853

Merged
merged 2 commits into from
Jun 5, 2017
Merged

Keep ZMQKernel class if restarted #853

merged 2 commits into from
Jun 5, 2017

Conversation

lgeiger
Copy link
Member

@lgeiger lgeiger commented Jun 5, 2017

This makes restarting a lot smother (and a bit faster):

  • only spawn a new kernel process and keep the ZMQ sockets open
  • don't clear the result bubbles on restart.

restart

Fixes #849
/cc @wowserx

@rgbkrk
Copy link
Member

rgbkrk commented Jun 5, 2017

Wow, sweet. I'm glad that worked so well.

@rgbkrk rgbkrk merged commit cf244c4 into nteract:master Jun 5, 2017
@lgeiger lgeiger deleted the smooth-restart branch June 5, 2017 01:44
@arl-o
Copy link
Contributor

arl-o commented Jun 5, 2017

Wow, this is awesome! Y'all are the speedy, communicative devs I aspire to become.

@t9md
Copy link
Contributor

t9md commented Jun 5, 2017 •
edited
Loading

With this PR, onRestarted callback is no longer called.
I want give it back, now plugin author have no control when they want to do after restart.

Should call onRestarted before return?

This was referenced Jun 5, 2017
Merged
Closed
@lgeiger lgeiger mentioned this pull request Jun 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lgeiger @rgbkrk @arl-o @t9md