Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slider resize hack #843

Merged
merged 2 commits into from
Jun 4, 2017
Merged

Remove slider resize hack #843

merged 2 commits into from
Jun 4, 2017

Conversation

lgeiger
Copy link
Member

@lgeiger lgeiger commented Jun 2, 2017

Once whoisandy/react-rangeslider#64 is shipped
we can remove
our hack for properly handling resizing

Once whoisandy/react-rangeslider#64 is shipped
we can remove
our hack for properly handling resizing
And add package-lock.json to gitignore
@lgeiger
Copy link
Member Author

lgeiger commented Jun 4, 2017

Now that react-rangeslider 2.1.0 is out, this is ready to go.

Copy link
Member

@BenRussert BenRussert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rgbkrk rgbkrk merged commit 09a682f into nteract:master Jun 4, 2017
@rgbkrk
Copy link
Member

rgbkrk commented Jun 4, 2017

I love merging things.

@lgeiger lgeiger deleted the range-slider branch June 4, 2017 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants