Don't focus on kernel monitor after toggling #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once you fix flow I approve |
|
ah I totally forget to run |
|
Im going to test this before merging, give me some time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Currently
toggle-kernel-monitoruses justatom.workspace.toggleAPI and after invoking the command our focus will be on the kernel-monitor pane and IMO most of the time we have to manually switch back to the previous editor (or pane in general).This is because, within kernel monitor, we just monitor it or click to do some action, and there is nothing to do with keybindings, thus there is no need to stay focus on it after toggling it.
Approach
This PR includes the workaround for
atom.workspace.toggleusingprevPanestuff, cause there seems no option fortoggleAPI unlikeopen...