Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Selecting Inside ResultViews #1652

Merged
merged 3 commits into from
Jun 4, 2019
Merged

Add Selecting Inside ResultViews #1652

merged 3 commits into from
Jun 4, 2019

Conversation

wadethestealth
Copy link
Member

The Issue

Currently, hydrogen does not allow for selecting only part of inline or multi-line ResultView's
This PR is a suggested approach that works.

Notes

@wadethestealth wadethestealth mentioned this pull request Jun 4, 2019
Closed
BenRussert
BenRussert approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@BenRussert BenRussert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is great! I've tried many times to figure this out and had pretty much given up!

@BenRussert BenRussert merged commit 8f6f583 into nteract:master Jun 4, 2019
@aviatesk aviatesk mentioned this pull request Jun 5, 2019
Closed
@wadethestealth wadethestealth deleted the selections branch June 6, 2019 15:20
@wadethestealth wadethestealth mentioned this pull request Jun 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenRussert BenRussert BenRussert approved these changes

Assignees
No one assigned
Labels
enhancement 🌟 New feature ideas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please allow selection of text from inline output
3 participants
@wadethestealth @BenRussert @aviatesk