Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Atom >= 1.28.0 #1553

Merged
merged 1 commit into from
Feb 23, 2019
Merged

Require Atom >= 1.28.0 #1553

merged 1 commit into from
Feb 23, 2019

Conversation

kylebarron
Copy link
Contributor

@kylebarron kylebarron commented Feb 22, 2019 •
edited
Loading

Fixes #1551

Atom 1.28.0 was released in June 2018 I believe. That's probably old enough to not inconvenience ourselves to support it. Thoughts?

lgeiger
lgeiger approved these changes Feb 23, 2019
View reviewed changes
Copy link
Member

@lgeiger lgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK to only support Atom >= 1.28.

@lgeiger lgeiger merged commit 1cfd97c into master Feb 23, 2019
@lgeiger lgeiger deleted the kylebarron-patch-1 branch February 23, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgeiger lgeiger lgeiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylebarron @lgeiger