Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated data explorer docs example #1490

Merged
merged 1 commit into from
Dec 30, 2018
Merged

Conversation

kylebarron
Copy link
Contributor

The data explorer example is listed twice
image

The data explorer example is listed twice
@BenRussert
Copy link
Member

Oh woops. Actually, I think we should just remove the example entirely. We never shipped the data-explorer as a built-in to hydrogen because it is in alpha and I didn't want to indicate that it was fully supported yet.

I created a data-explorer plugin where I am working through the various issues with using the data-explorer within atom. Now that I mention it, I have some work to do to get an updated version of this plugin shipped as the data-explorer itself is rapidly developing.

@kylebarron
Copy link
Contributor Author

kylebarron commented Dec 11, 2018

Right, that makes sense. As long as there's documentation in the plugin itself, we probably don't need to include those examples.

@BenRussert
Copy link
Member

Did you want to cut the rest of the example out before we merge?

@kylebarron
Copy link
Contributor Author

On second thought, I don't have a problem with leaving that at the bottom of the examples, if only to advertise the data explorer more.

@lgeiger
Copy link
Member

lgeiger commented Dec 27, 2018

On second thought, I don't have a problem with leaving that at the bottom of the examples, if only to advertise the data explorer more.

I agree, we should add a link to the data explorer plugin.

@lgeiger
Copy link
Member

lgeiger commented Dec 30, 2018

We can add links to the plugin in a future PR.

@lgeiger lgeiger merged commit 4784af0 into master Dec 30, 2018
@lgeiger lgeiger deleted the kylebarron-patch-1 branch December 30, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants