Change isSingeLine to support null or undefined text #1384
Conversation
This happened when we tried connecting hydrogen to a tweaked Jupiter server. It worked nicely with this change.
|
Hi, thanks for the PR. I don't follow what you mean, could you clarify what the issue is and how this will fix it? |
There was a problem hiding this comment.
Sounds like you found a bug and fixed it, that is pretty cool in my book! I'd love if you would comment on what you found so we know!
Let me know if you want to add that flow type from my comment otherwise I will probably just merge this.
Thank you, and congrats on your first PR!
lib/store/output.js
Outdated
| @@ -57,7 +57,7 @@ export function reduceOutputs( | |||
| export function isSingeLine(text: string, availableSpace: number) { | |||
There was a problem hiding this comment.
Since you have discovered a bug that allows undefined values to sneak in, we should change this text: string to a flow maybe type, which looks like this: text: ?string.
The ?string type will tip flow off that it is possible for the argument text to be undefined. Then flow will warn us that we need to handle the case where text === undefined.
Based on the comment: nteract#1384 (comment)
|
Fixing null case as well |
abendafb
changed the title
|
BTW, is it isSingeLine on purpose? |
|
Thanks @abendafb!
No, probably not. |
With: @lsaddan
This happened when we tried connecting hydrogen to a tweaked Jupiter server.
It worked nicely with this change.