Fix session name display in WSKernelPicker #1247
Merged
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to #1245
model.notebook.path
does not exist for kernels spawned from hydrogen, butmodel.path
does.In general, the schema for session model objects has undergone some changes in the past year or so. Once Jupyterlab and
@jupyter/services
get to the point of actually having a stable developer API, we can consider additional changes (such as taking advantage of thename
field instead of pretending that everything is a path)