Add specs for history slider #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgeiger
requested changes
Oct 17, 2017
| @@ -0,0 +1,47 @@ | |||
| /* @flow */ | |||
There was a problem hiding this comment.
If you remove this line, CI will go green. Otherwise we'd need to configure flow properly.
There was a problem hiding this comment.
I've noticed that and did a second commit on my repo. Do you know why it doesn't show up in the pull request?
Edit: It did now, perhaps it just takes time
lgeiger
reviewed
Oct 17, 2017
| Enzyme.configure({ adapter: new Adapter() }); | ||
|
|
||
| import store from "../../../lib/store"; | ||
| import Kernel from "../../../lib/kernel"; |
There was a problem hiding this comment.
I think those lines can be removed too:
import store from "../../../lib/store";
import Kernel from "../../../lib/kernel";
lgeiger
approved these changes
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rudimentary set of tests for the history slider. (Just testing basic rendering and the arrow buttons)
Ref #813