Upgrade @jupyterlab/services@0.50.0 #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgeiger
commented
Oct 13, 2017
| @@ -122,7 +122,7 @@ export default class WSKernel extends Kernel { | |||
| defaultText: this.session.path, | |||
| allowCancel: true | |||
| }, | |||
| (input: string) => this.session.rename(input) | |||
| (input: string) => this.session.setPath(input) | |||
There was a problem hiding this comment.
This doesn't change behavior. Though we should now use the session name in the UI instead of the notebook path.
There was a problem hiding this comment.
We use the name unless it is an empty string and then defer to the basename of the path.
|
Looks good! You can update to |
|
Missed some of the source maps in 0.50.1, 0.50.2 has them all. |
|
Thanks, lets get up to date 🎉 |
blink1073
approved these changes
Oct 13, 2017
rgbkrk
approved these changes
Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @blink1073 for the sessions backport 👍
Closes #1042
Closes #781
Closes #908