Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with Atom 1.22 #1036

Merged
merged 1 commit into from
Oct 10, 2017
Merged

Fix compatibility with Atom 1.22 #1036

merged 1 commit into from
Oct 10, 2017

Conversation

lgeiger
Copy link
Member

@lgeiger lgeiger commented Oct 9, 2017

Atom 1.22 removed the unofficial languageMode API: atom/atom#15713

Fixes #1034

It would be great if someone could give this a quick spin in Atom 1.21, I only tested it on 1.22

@lgeiger lgeiger added the bug 🐛 For unexpected issues label Oct 9, 2017
@rgbkrk
Copy link
Member

rgbkrk commented Oct 9, 2017

Since you do some checking of versions here, I think this is fine to go out since it straddles the old API.

@lgeiger
Copy link
Member Author

lgeiger commented Oct 10, 2017

Since you do some checking of versions here, I think this is fine to go out since it straddles the old API.

Yeah it should work fine.

@rgbkrk rgbkrk merged commit b3d9710 into nteract:master Oct 10, 2017
@lgeiger lgeiger deleted the language-mode branch October 10, 2017 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgbkrk rgbkrk rgbkrk approved these changes

Assignees
No one assigned
Labels
bug 🐛 For unexpected issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgeiger @rgbkrk