Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernelspec user config is ignored on update-kernels #856

Closed
t9md opened this issue Jun 5, 2017 · 2 comments
Closed

kernelspec user config is ignored on update-kernels #856

t9md opened this issue Jun 5, 2017 · 2 comments

Comments

@t9md
Copy link
Contributor

t9md commented Jun 5, 2017

Description:

updateKernelSpecs function ignore user config.
Because of bug.

this._kernelSpecs = this.getKernelSpecsFromSettings;

Should be

this._kernelSpecs = this.getKernelSpecsFromSettings();

https://github.com/nteract/hydrogen/blob/master/lib/kernel-manager.js#L244

[Description of the issue]

Steps to Reproduce:

  1. Set JSON on kernelspec config with proper field with debug print insertion
  2. See user config ignored and noticed code bug.

Versions:

Which OS and which version of Hydrogen and Atom are you running?

  • MacOS(10.12.5)
  • ijavascript

You can get this information from copy and pasting the output of atom --version from the command line.

Atom    : 1.18.0-beta2
Electron: 1.3.15
Chrome  : 52.0.2743.82
Node    : 6.5.0

Logs:

Please post any error logs and the output of the developer tools as described in our Debugging Guide.

@BenRussert
Copy link
Member

@t9md Your proposed solution makes sense to me, want to make a PR to close this?

@t9md
Copy link
Contributor Author

t9md commented Jun 11, 2017

No.

BenRussert added a commit to BenRussert/hydrogen that referenced this issue Jun 11, 2017
@rgbkrk rgbkrk closed this as completed in dca3293 Jun 12, 2017
t9md pushed a commit to t9md/hydrogen that referenced this issue Jun 14, 2017
pfackeldey pushed a commit to pfackeldey/hydrogen that referenced this issue Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants