Skip to content

Commit

Permalink
Merge pull request #1566 from BenRussert/import-notebook-from-treeview
Browse files Browse the repository at this point in the history
Add right-click context menu for import-notebook
  • Loading branch information
BenRussert authored Apr 8, 2019
2 parents 2442fa2 + ef03074 commit 352e5cf
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 10 deletions.
8 changes: 7 additions & 1 deletion lib/import-notebook.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,13 @@ export function ipynbOpener(uri: string) {
}
}

export function importNotebook() {
export function importNotebook(event?: atom$CustomEvent) {
// Use selected filepath if called from tree-view context menu
const filenameFromTreeView = _.get(event, "target.dataset.path");
if (filenameFromTreeView && path.extname(filenameFromTreeView) === ".ipynb") {
return _loadNotebook(filenameFromTreeView);
}

dialog.showOpenDialog(
{
properties: ["openFile"],
Expand Down
2 changes: 1 addition & 1 deletion lib/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ const Hydrogen = {
if (!kernel) return;
kernel.outputStore.clear();
},
"hydrogen:import-notebook": () => importNotebook()
"hydrogen:import-notebook": importNotebook
})
);

Expand Down
11 changes: 3 additions & 8 deletions menus/hydrogen.cson
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
# See https://atom.io/docs/latest/hacking-atom-package-word-count#menus for more details
# 'context-menu':
# 'atom-text-editor': [
# {
# 'label': 'Toggle atom-repl'
# 'command': 'atom-repl:toggle'
# }
# ]
'context-menu':
'.tree-view .file .name[data-name$=\\.ipynb]':
[{label: 'Import Notebook', command: 'hydrogen:import-notebook'}]
'menu': [
{
'label': 'Packages'
Expand Down
5 changes: 5 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@
"versions": {
"^1.0.0": "consumeStatusBar"
}
},
"tree-view": {
"versions": {
"^1.0.0": "consumeTreeView"
}
}
},
"providedServices": {
Expand Down

0 comments on commit 352e5cf

Please sign in to comment.