remove godep in favor of gpm #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RFR @jehiah |
mreiferson
force-pushed
the
bye_godep_458
branch
from
5bd2054
to
4e058c3
Compare
|
👍 |
| } | ||
| ] | ||
| } | ||
| code.google.com/p/snappy-go/snappy 12e4b4183793ac4b061921e7980845e750679fd0 |
There was a problem hiding this comment.
can we comment human readable versions on these lines (where we have such a thing) or the date they were last bumped or something? (looks like anything after # should be treated as a comment)
There was a problem hiding this comment.
in terms of date of bumps, that's all in the git history
|
LGTM aside from that small detail |
mreiferson
force-pushed
the
bye_godep_458
branch
from
4e058c3
to
c460b27
Compare
|
updated and squashed in gonna separately bump some deps after this and #404 lands |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gpm is exactly the kind of lightweight tool we're looking for in order to automate reproducible builds from a list of dependencies.
Unfortunately godep went in a different (valid) direction.