consumer: expose message Source #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mreiferson
force-pushed
the
source_92
branch
2 times, most recently
from
e565f16
to
6992dc0
Compare
|
ping @jehiah |
| @@ -23,6 +23,8 @@ type Message struct { | |||
| Timestamp int64 | |||
| Attempts uint16 | |||
|
|
|||
| Source string | |||
There was a problem hiding this comment.
I feel like there could easily be confusion about this being nsqd source not producer source; Can you add a docstring here?
There was a problem hiding this comment.
It is the nsqd source (i.e. the nsqd connection that delivered the message)
Naming, perhaps?
|
LGTM comment asside |
mreiferson
force-pushed
the
source_92
branch
from
6992dc0
to
da9a41a
Compare
jehiah
added a commit
that referenced
this pull request
Dec 23, 2014
consumer: expose message Source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open for discussion - this is one (simple) way to expose the source
nsqd that delivered the message.
in my case, I used this to remove a head-of-line blocking issue
where a single bad actor was preventing an application from making
progress.