Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config doesn't accept -1 for output_buffer_timeout #87

Merged
merged 1 commit into from
Oct 24, 2014
Merged

Config doesn't accept -1 for output_buffer_timeout #87

merged 1 commit into from
Oct 24, 2014

Conversation

mreiferson
Copy link
Member

From nsqio/nsq#473 (comment)

I noticed something odd: IDENTIFY expects -1 to disable the output buffer timeout. nsq.Config, on the other hand, expects 0 to disable the timeout and doesn't accept -1 because it's not a valid duration.

@grantr grantr mentioned this pull request Oct 23, 2014
Closed
@mreiferson mreiferson added the bug label Oct 24, 2014
@mreiferson
Copy link
Member

RFR

jehiah added a commit that referenced this pull request Oct 24, 2014
@jehiah
Merge pull request #87 from mreiferson/fix_disable_identify_87
760d55a 
Config doesn't accept -1 for output_buffer_timeout
@jehiah jehiah merged commit 760d55a into nsqio:master Oct 24, 2014
@mreiferson mreiferson deleted the fix_disable_identify_87 branch October 25, 2014 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mreiferson @jehiah