Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS Config copy fix #255

Merged
merged 1 commit into from
Dec 24, 2019
Merged

TLS Config copy fix #255

merged 1 commit into from
Dec 24, 2019

Conversation

iaburton
Copy link
Contributor

Fixes #254

I also ended up moving the net.SplitHostPort code up so if it failed we don't make a new tls.Config/clone for nothing.

conn.go Outdated Show resolved Hide resolved
@ploxiln
Copy link
Member

ploxiln commented Mar 28, 2019

one last thing: can you squash down to 1 commit?

also move tls.Config clone after net.SplitHostPort

closes nsqio#254
@ploxiln ploxiln merged commit 4b82735 into nsqio:master Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-vet: assignment copies lock value of tls.Config
3 participants