Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor #19

Merged
merged 4 commits into from
Apr 9, 2014
Merged

refactor #19

merged 4 commits into from
Apr 9, 2014

Commits on Apr 8, 2014

  1. reader: separate out Configure

    @mreiferson
    mreiferson committed Apr 8, 2014
    Configuration menu
    Copy the full SHA
    a728c03 View commit details
    Browse the repository at this point in the history

  2. configure: fix bool check

    @mreiferson
    mreiferson committed Apr 8, 2014
    Configuration menu
    Copy the full SHA
    d293313 View commit details
    Browse the repository at this point in the history

  3. reader: separate out errors

    @mreiferson
    mreiferson committed Apr 8, 2014
    Configuration menu
    Copy the full SHA
    1ba8845 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2014

  1. reader/writer/conn: refactoring 

    * make Conn public
* move transport responsibilities into Conn from Reader/Writer
* supply callbacks for hooking into Conn events
* name anon cleanup func; add to wg
* ensure that readLoop exits before exiting cleanup
* always check messagesInFlight at readLoop exit
* close underlying connection last
    @mreiferson
    mreiferson committed Apr 9, 2014
    Configuration menu
    Copy the full SHA
    1518027 View commit details
    Browse the repository at this point in the history