consumer: update FullJitterStrategy Calculate to not bound by MaxBackoffDuration #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
judwhite
commented
Jul 15, 2015
judwhite
commented
- responsibility has been moved to Consumer startStopContinueBackoff
- see PR consumer: fix max_backoff_duration #147 and consumer: backoff option max_backoff_level #142
|
I was just about to say, it's not a "problem" but it is duplicate and unnecessary work. Thanks for noticing/fixing! |
|
I thought it would be a problem because of this https://github.com/bitly/go-nsq/blob/cfe4feafe8d2eccdd377c18eae70ba564f2d74ae/consumer.go#L780-L783 |
|
I missed that! |
mreiferson
added a commit
that referenced
this pull request
Jul 15, 2015
update FullJitterStrategy Calculate to not bound by MaxBackoffDuration
mreiferson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.