producer: fix connection race #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, it is possible for more than one goroutine to
check:
if atomic.LoadInt32(&w.state) != StateConnected {
...thereafter calling w.connect. w.connect first grabs a lock on
w.guard, and then asserts that it be the only goroutine attempting a
connection:
if !atomic.CompareAndSwapInt32(&w.state, StateInit, StateConnected) {
return ErrNotConnected
}
This means if there are two parallel actions which attempt to initiate
the connection, one of them will return ErrNotConnected if the first
succesfully connected.
|
LGTM, nice catch! Thanks! |
mreiferson
added a commit
that referenced
this pull request
Apr 8, 2015
producer: fix connection race
mreiferson
added a commit
to mreiferson/go-nsq
that referenced
this pull request
Apr 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, it is possible for more than one goroutine to
check:
...thereafter calling w.connect. w.connect first grabs a lock on
w.guard, and then asserts that it be the only goroutine attempting a
connection:
This means if there are two parallel actions which attempt to initiate
the connection, one of them will return ErrNotConnected if the first
succesfully connected.