Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop notary-less code and data from all contracts except mainnet one #303

Closed
roman-khimov opened this issue Dec 30, 2022 · 1 comment · Fixed by #324
Closed

Drop notary-less code and data from all contracts except mainnet one #303

roman-khimov opened this issue Dec 30, 2022 · 1 comment · Fixed by #324
Assignees
Labels
enhancement Improving existing functionality
Milestone

Comments

@roman-khimov
Copy link
Member

We can have notary subsystem on all public chains now and every private installation also uses it anyway, so notary-less code is only needed for the mainnet neofs contract. Some preliminary work has been done for this in the enable-notary-in-public-chains branch (https://github.com/nspcc-dev/neofs-contract/tree/enable-notary-in-public-chains), but it needs to be extended. The most important thing here is to ensure smooth migration to notary-enabled reality (including notary deposits and the proxy contract that is completely missing in non-notary setups).

@roman-khimov
Copy link
Member Author

roman-khimov commented Feb 6, 2023

  • alphabet contract migration cost should add notary deposits for all IR and SNs
  • it also should send a half of its GAS to the proxy contract (assuming it's pre-deployed)
  • all contracts should check for their voting data to not contain any ongoing votes (panicing otherwise)
  • old voting data must be dropped
  • notaryDisabled settings must be dropped (except for _deploy parameters, it's cheaper to have them there for now to keep neofs-adm compatibility)

It's one-way migration. Contracts are to be tested using real mainnet data (hi, #281).

cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Feb 10, 2023
TBD

Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
roman-khimov added a commit that referenced this issue Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants