use componentDidMount and ignore async results if componenent has bee…

…n unmounted
nreese · Jan 8, 2018 · ac8df5d · ac8df5d
1 parent 479c731
commit ac8df5d
Showing 1 changed file with 16 additions and 1 deletion.
diff --git a/src/core_plugins/kibana/public/home/components/tutorial/tutorial.js b/src/core_plugins/kibana/public/home/components/tutorial/tutorial.js
@@ -30,13 +30,28 @@ export class Tutorial extends React.Component {
     }
   }
 
-  async componentWillMount() {
+  componentWillMount() {
+    this._isMounted = true;
+  }
+
+  componentWillUnmount() {
+    this._isMounted = false;
+  }
+
+  async componentDidMount() {
     const tutorial = await this.props.getTutorial(this.props.tutorialId);
+
+    if (!this._isMounted) {
+      return;
+    }
+
     if (tutorial) {
+      // eslint-disable-next-line react/no-did-mount-set-state
       this.setState({
         tutorial: tutorial
       }, this.setParamDefaults);
     } else {
+      // eslint-disable-next-line react/no-did-mount-set-state
       this.setState({
         notFound: true,
       });