Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't exclude test directories #3

Merged
merged 1 commit into from
Sep 8, 2017
Merged

Don't exclude test directories #3

merged 1 commit into from
Sep 8, 2017

Conversation

iarna
Copy link
Contributor

@iarna iarna commented Sep 8, 2017

Adding new exclusions to what goes in published artifacts is breaking for npm and the code this replaces didn't exclude tests by default.

The breakingness is definitely a judgement call. I wouldn't view adding more exclusions for gyp temp files or editor cruft as breaking, for example.

@isaacs
Copy link
Contributor

isaacs commented Sep 8, 2017

Weird, I seem to recall having some kind of reason for that, but it strikes me now as obviously wrong. Please do land this, lgtm, thank you.

@isaacs isaacs merged commit 68dd6bd into master Sep 8, 2017
@noahsilas
Copy link

Thanks for this fix - due to an unusual design decision some time ago, some private repos I'm working in are sharing some tests by putting them into a shared package's test directory, and trying to read those tests in the dependant repos is failing under npm 5.4.1.

In my particular case, I was able to add a .npmignore whitelist entry to the shared repo (!test), but that meant that I had to cut new versions of that repo and update that dependency at the same time as moving up to npm 5.4. 😅

@lukekarrys lukekarrys deleted the keep-tests branch August 18, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants