Add support for time-traveling installs. #90
Conversation
doc/misc/npm-config.md
Outdated
| @@ -350,6 +350,21 @@ commands, eg `dist-tags`, `owner`, etc. | |||
|
|
|||
| The command to run for `npm edit` or `npm config edit`. | |||
|
|
|||
| ### enjoy-by | |||
There was a problem hiding this comment.
As mentioned on Twitter, this does also need a more straightforward name, especially for non-English speakers.
There was a problem hiding this comment.
Oh I forgot to push the commit. I aliased it to --before.
There was a problem hiding this comment.
I almost did --published-by, but after seeing it, realized it looked like it wanted a maintainer name, not a timestamp.
lib/install.js
Outdated
| @@ -703,8 +703,25 @@ Installer.prototype.cloneCurrentTreeToIdealTree = function (cb) { | |||
| validate('F', arguments) | |||
| log.silly('install', 'cloneCurrentTreeToIdealTree') | |||
|
|
|||
| this.idealTree = copyTree(this.currentTree) | |||
| this.idealTree.warnings = [] | |||
| if (npm.config.get('enjoy-by')) { | |||
There was a problem hiding this comment.
This does have potentially interesting interactions with lock files, which is to say, I'm not sure it does anything in the presence of a valid lock file. We should probably warn in that scenario, as otherwise we're setting up a foot gun.
|
just like just tried |
zkat
force-pushed
the
zkat/registry-fetch-replacement
branch
4 times, most recently
from
faa224c
to
fcdbeae
Compare
zkat
force-pushed
the
zkat/registry-fetch-replacement
branch
6 times, most recently
from
6e607fe
to
813905c
Compare
zkat
changed the base branch from
zkat/registry-fetch-replacement
to
release-next
zkat
force-pushed
the
zkat/enjoy-by
branch
3 times, most recently
from
27bcbe4
to
749dd8d
Compare
zkat
added
semver:minor
zkat
force-pushed
the
zkat/enjoy-by
branch
2 times, most recently
from
50b63fc
to
49eb8e1
Compare
No description provided.