Commits on Oct 15, 2018

1. Close the file descriptor if exiting upload via an error. …

   This fixes https://npm.community/t/unhelpful-error-message-when-publishing-without-logging-in-error-eperm-operation-not-permitted-unlink/1377/3 and the other dozen or so issues that that link references, and possibly many more involving poor error messages from errors thrown by the upload function. 
   
   @zkat you mentioned you could take a look at any fixes / answer any questions, if you could look this over and let me know if this is a good / valid approach that would be fantastic, thanks! (it wasn't a race condition, luckily :P).
   
   it may also be helpful to add something like 
   ```
       if (!auth.token || !(auth.username && auth.password)) {
         log.warn('publish', 'not logged in')
       }
   ```
   just before we even open the first file descriptor to make sure that even if the error message is completely wrong something in the log will give users a clue what may be going on. I took the method of looking for login creds from the logout method, I'm not sure that's valid or if alternatives to npm exist that don't require credentials but users could still publish to.
   
   Triage of the issue:
   
   1. The upload function throws an error
   2. As that error bubbles through [cacache](https://www.npmjs.com/package/cacache#with-tmp) it tries to delete the tmpdir as it should
   3. It can't delete the temp dir as the upload function's readFileStream to the tar it was trying to upload is still open.
   4. [cacache](https://www.npmjs.com/package/cacache#with-tmp) throws an error about it's inability to remove the dir, which suppresses the upload function's error.

   

   macdja38 committed Oct 15, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for e9d41bd
   • Browse repository at this point

   Copy the full SHA

   e9d41bd View commit details

   Browse the repository at this point in the history