Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in all libnpm modules + arborist as workspaces #4166

Merged
merged 19 commits into from
Dec 16, 2021

Conversation

fritzy
Copy link
Contributor

@fritzy fritzy commented Dec 12, 2021

  • Brings in more workspaces to the CLI
    • arborist
    • libnpmaccess
    • libnpmdiff
    • libnpmexec
    • libnpmfund
    • libnpmhook
    • libnpmorg
    • libnpmpack
    • libnpmpublish
    • libnpmsearch
    • libnpmteam
    • libnpmversion
  • Updates tap for all workspaces to tap@15

@ljharb
Copy link
Contributor

ljharb commented Dec 14, 2021

This seems like it will make bug reports on specific subpackages easily lost in the noise of cli issues :-/ the issues in this repo already seem quite difficult for the cli team to keep up with.

@npm-robot
Copy link
Contributor

npm-robot commented Dec 14, 2021

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 62.503 ±6.80 36.846 ±0.00 23.106 ±0.07 25.563 ±1.01 3.636 ±0.02 3.802 ±0.17 2.976 ±0.06 15.565 ±0.21 2.881 ±0.05 3.746 ±0.00
#4166 0.517 ±0.01 0.489 ±0.01 0.537 ±0.02 0.482 ±0.00 0.495 ±0.01 0.495 ±0.01 0.511 ±0.02 0.508 ±0.01 0.502 ±0.02 0.504 ±0.02
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 44.567 ±1.24 28.049 ±0.29 16.391 ±0.22 18.006 ±0.00 3.465 ±0.02 3.511 ±0.15 3.082 ±0.14 11.643 ±0.27 2.858 ±0.05 3.484 ±0.03
#4166 0.482 ±0.01 0.501 ±0.02 0.505 ±0.01 0.510 ±0.01 0.498 ±0.02 0.491 ±0.01 0.495 ±0.00 0.479 ±0.00 0.504 ±0.00 0.493 ±0.00

@fritzy fritzy marked this pull request as ready for review December 14, 2021 22:18
@fritzy fritzy requested a review from a team as a code owner December 14, 2021 22:18
@darcyclarke
Copy link
Contributor

@ljharb reducing the surface area/channels we need to monitor should actually help us to maintain these projects long-term. To your point, we'll definitely be making a push in the New Year to address the current backlog but I think this PR is a step in the right direction.

@wraithgar wraithgar changed the base branch from latest to release-next December 15, 2021 17:34
@fritzy fritzy merged commit 6f63055 into release-next Dec 16, 2021
@fritzy fritzy deleted the fritzy/more-workspaces branch December 16, 2021 18:01
fritzy added a commit that referenced this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants