Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.12.0 #264

Merged
merged 27 commits into from
Oct 8, 2019
Merged

Release 6.12.0 #264

merged 27 commits into from
Oct 8, 2019

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Oct 8, 2019

6.12.0 (2019-10-08):

Now npm ci runs prepare scripts for git dependencies, and respects the --no-optional argument. Warnings for engine mismatches are printed again. Various other fixes and cleanups.

BUG FIXES

FEATURES

  • ed993a29c #249 Add CI environment variables to user-agent (@isaacs)
  • f6b0459a4 #248 Add option to save package-lock without formatting Adds a new config --format-package-lock, which defaults to true. (@bl00mber)

DEPENDENCIES

TESTING

Michael Perrotte and others added 25 commits September 24, 2019 15:23
- fix: filter functions and undefined out of makeEnv (@isaacs)
- fix: pack git directories properly (@claudiahdz)
- respect no-optional argument (@cruzdanilo)
PR-URL: #260
Credit: @isaacs
Close: #260
Reviewed-by: @isaacs
It seems that a couple of lines were missed when token.js was [changed
to use figgyPudding][1] which [causes an error][2] when trying to run
that command in certain circumstances.  This patch fixes that error.

[1]: 4cf850d#diff-398ed3b014436a5204583323ea29320b
[2]: https://npm.community/t/npm-token-err-figgypudding-options-cannot-be-modified-use-concat-instead/10288

PR-URL: #259
Credit: @benblank
Close: #259
Reviewed-by: @isaacs
The `npm-in-ci` header has been sent for some time now by
make-fetch-happen, but User-Agent is more reliably logged and respected
by proxies and CDNs, so that's a better place to put this.

PR-URL: #249
Credit: @isaacs
Close: #249
Reviewed-by: @isaacs
- Fixed setting engine check warnings to each package
- Added proper catching of package warnings during validation phase
- Added tap test that validates print of engine warn msgs

Fix: https://npm.community/t/engines-and-engines-strict-ignored/4792

PR-URL: #257
Credit: @ruyadorno
Close: #257
Reviewed-by: @isaacs
Adds a new config `--format-package-lock`, which defaults to true.

If set to false, then the package lock will be written without any
indentation or line breaks.

PR-URL: #248
Credit: @bl00mber
Close: #248
Reviewed-by: @isaacs

Note: squashed and edited slightly for style. -- @isaacs
Pushing back a week to fix some bugs that have been found.

- Engine check warnings get written to package.json, resulting in weird
  behavior later.
- GitLab URL parsing needs a bit more tweaks to handle urls like
  /user/repo/repository/ref/archive.tar.gz
Currently all of our tests verify on teardown that there are no
root-owned files in the cache.

However, owing to some race conditions and slippery stream event
deferral behavior that won't be fixed until v7, occasionally cacache's
chown doesn't get processed until _after_ the promise resolves and the
test ends.

As a result, sometimes this check occurs before the chown has happened,
resulting in flaky hard-to-reproduce failures.

The somewhat-kludgey solution here is to move the ownership check from
t.teardown to process.on('exit').  In npm v7, we should move it back to
t.teardown, because we should never have a test that resolves in such a
way as to leave the cache in an invalid state.

PR-URL: #262
Credit: @isaacs
Close: #262
Reviewed-by: @isaacs
PR-URL: #241
Credit: @gemal
Close: #241
Reviewed-by: @isaacs
@isaacs isaacs requested a review from a team October 8, 2019 00:33
@isaacs isaacs merged commit 44ddd0b into latest Oct 8, 2019
@herrernst
Copy link

I've just upgraded to 6.12.0, but prepare scripts for git dependencies are still not run on npm ci (was working before in 6.10.3).

@isaacs
Copy link
Contributor Author

isaacs commented Oct 10, 2019

@herrernst Do you have an example that you can share?

There is a chance that a hard cache reset can solve the problem (just judging from someone else's experience who was running into this). rm -rf ~/.npm would do it.

@herrernst
Copy link

Thanks, after removing ~/.npm, it seems to work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants