Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToDate/ToTimestamp non-nullable #3146

Merged
merged 1 commit into from
Apr 2, 2024
Merged

ToDate/ToTimestamp non-nullable #3146

merged 1 commit into from
Apr 2, 2024
+2 −2

Conversation

WhatzGames
Copy link
Contributor

Discussed in #3059

@WhatzGames
Copy link
Contributor Author

I'm not too sure whether to adjust the translation file as well with this one.
From my understanding, the SqlFunctionExpression created, should represent the function the way it is defined in Postgres.
So it should be correct already.

Unless I'm missing something obvious here.

roji
roji approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There's indeed no further change necessary as far as I can see.

@roji roji merged commit 18008c9 into npgsql:main Apr 2, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WhatzGames @roji