-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cobra cli for docker-generate command #250
Conversation
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
Signed-off-by: zaihaoyin <chloeyinbetter@outlook.com>
Signed-off-by: zaihaoyin <chloeyinbetter@outlook.com>
Signed-off-by: zaihaoyin <chloeyinbetter@outlook.com>
Signed-off-by: zaihaoyin <chloeyinbetter@outlook.com>
Signed-off-by: zaihaoyin <chloeyinbetter@outlook.com>
Are we going to support docker plugin in notation? If not then we can get rid of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the move to cobra.
@priteshbandi - I created a new discussion for dropping those commands. I believe it is a good thing to consider. I think we should not hold up this PR though on the outcome of the discussion. However @chloeyin I do think you should skip the |
Yes, I can skip the |
Since the plan from the discussion yesterday is to remove this and we have two code reviews/approvals from our side. I'm going to go ahead and merge it. |
Signed-off-by: zaihaoyin zaihaoyin@microsoft.com
What
Fix #183 by using
github.com/spf13/cobra
to replacegithub.51.al/urfave/cli/v2
, which is a cli package also used by oras-cli.Notice
The whole PR will update about 50 files, which is too difficult to review. I will split them into 4 PRs.
I expect these 4 PRs will do different jobs:
docker-generate
command to usecobra
and add some common flags whichcobra
will use in later PRs.docker-notation
command to usecobra
.notation
command to usecobra
.This is the first PR of the series.