Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add license header to files and github action workflow to check license #154

Merged
merged 6 commits into from
Jul 18, 2023

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Jul 12, 2023

Resolves #149

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts changed the title feat: add license headers to files and github action workflow to check lincese feat: add license header to files and github action workflow to check lincese Jul 12, 2023
@Two-Hearts Two-Hearts self-assigned this Jul 12, 2023
@Two-Hearts Two-Hearts added the enhancement New feature or request label Jul 12, 2023
@Two-Hearts Two-Hearts added this to the 1.0.0 milestone Jul 12, 2023
@Two-Hearts Two-Hearts changed the title feat: add license header to files and github action workflow to check lincese feat: add license header to files and github action workflow to check license Jul 12, 2023
shizhMSFT
shizhMSFT previously approved these changes Jul 12, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

.github/workflows/license-checker.yml Show resolved Hide resolved
@Two-Hearts Two-Hearts changed the title feat: add license header to files and github action workflow to check license chore: add license header to files and github action workflow to check license Jul 12, 2023
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #154 (27c03d0) into main (02fc54a) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files          21       21           
  Lines        1693     1693           
=======================================
  Hits         1509     1509           
  Misses        149      149           
  Partials       35       35           
Impacted Files Coverage Δ
revocation/ocsp/errors.go 100.00% <ø> (ø)
revocation/ocsp/ocsp.go 81.39% <ø> (ø)
revocation/result/errors.go 100.00% <ø> (ø)
revocation/result/results.go 100.00% <ø> (ø)
revocation/revocation.go 100.00% <ø> (ø)
signature/algorithm.go 100.00% <ø> (ø)
signature/cose/envelope.go 93.24% <ø> (ø)
signature/envelope.go 100.00% <ø> (ø)
signature/errors.go 94.73% <ø> (ø)
signature/internal/base/envelope.go 97.72% <ø> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/license-checker.yml Outdated Show resolved Hide resolved
.github/workflows/license-checker.yml Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 6a0651c into notaryproject:main Jul 18, 2023
7 checks passed
@Two-Hearts Two-Hearts deleted the license branch July 18, 2023 02:03
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
6 tasks
fanndu pushed a commit to fanndu/notation-core-go that referenced this pull request Jul 21, 2023
fanndu pushed a commit to fanndu/notation-core-go that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check the license header for notation-core-go and its dependencies
5 participants