Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: remove toHex and toBase64 #3300

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Conversation

nwf
Copy link
Member

@nwf nwf commented Sep 28, 2020

We marked these for deprecation in favor of the functions of the same
name in encoder. Let's actually make good on that.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

We marked these for deprecation in favor of the functions of the same
name in encoder.  Let's actually make good on that.
@marcelstoer marcelstoer added this to the Next release milestone Sep 28, 2020
@marcelstoer marcelstoer merged commit 0a1d122 into nodemcu:dev Sep 28, 2020
@nwf nwf deleted the crypto-rm-deprecated branch September 28, 2020 19:29
marcelstoer pushed a commit that referenced this pull request Nov 7, 2020
We marked these for deprecation in favor of the functions of the same
name in encoder.  Let's actually make good on that.
vsky279 pushed a commit to vsky279/nodemcu-firmware that referenced this pull request Nov 21, 2020
We marked these for deprecation in favor of the functions of the same
name in encoder.  Let's actually make good on that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants