Revise fifo{,sock} #2671
Merged
Revise fifo{,sock} #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwf
referenced
this pull request
Feb 16, 2019
) * lua_modules/fifo: a generic queue & socket wrapper One occasionally wants a generic fifo, so here's a plausible implementation that's reasonably flexible in its usage. One possible consumer of this is a variant of TerryE's two-level fifo trick currently in the telnetd example. Factor that out to fifosock for more general use. * lua_examples/telnet: use factored out fifosock * lua_modules/http: improve implementation Switch to fifosock for in-order sending and waiting for everything to be sent before closing. Fix header callback by moving the invocation of the handler higher * fifosock: optimistically cork and delay tx If we just pushed a little bit of data into a fifosock that had idled, wait a tick (1 ms) before transmitting. Hopefully, this means that we let the rest of the system push more data in before we send the first packet. But in a high-throughput situation, where we are streaming data without idling the fifo, there won't be any additional delay and we'll coalesce during operation as usual. The fifosocktest mocks up enough of tmr for this to run, but assumes an arbitrarily slow processor. ;)
Fixes to nodemcu#2650: - Convert fifosock to returning tables containing ctors - Improve docs - Add a missed :on("sent", nil) in the http server
|
@marcelstoer If @TerryE signs off on these small fixups, can they be scheduled to go before the next drop? |
|
I haven't had the time to dynamic test this, but in general this is an excellent example. No doubt we can refine our coding and implementation styles as LFS etc. evolves. My only real quibble is that I feel that @nwf Nathaniel is doing himself a disservice by listing me as the principle author, given that the bulk of the implementation is his. He should take the main credit here not me. |
|
@TerryE All I did was copy code from the telnet server example and introduce bugs. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch rather than formaster.docs/en/*.@TerryE raises a number of good points on the
fifoandfifosockPR (#2650) which was perhaps prematurely committed. This PR is to address those comments.