Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix to telnet Lua example and ftpserver Lua module #2654

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Minor fix to telnet Lua example and ftpserver Lua module #2654

merged 1 commit into from
Feb 13, 2019

Conversation

vsky279
Copy link
Contributor

@vsky279 vsky279 commented Feb 10, 2019

Fixes telnet lua example and ftpserver lua module in consequence of Expunge of integer timers (PR #2603)

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/en/*.

marcelstoer
marcelstoer requested changes Feb 10, 2019
View reviewed changes
lua_examples/telnet/telnet.lua Outdated Show resolved Hide resolved
lua_examples/telnet/telnet.lua Outdated Show resolved Hide resolved
lua_examples/telnet/telnet.lua Outdated Show resolved Hide resolved
lua_examples/telnet/telnet.lua Outdated Show resolved Hide resolved
@marcelstoer marcelstoer added this to the Next release milestone Feb 10, 2019
@nwf
Copy link
Member

nwf commented Feb 10, 2019

Be advised that the telnet changes will conflict with #2650 (which also dealt with the fallout of #2603). I don't mind merging this one first, if desired.

@vsky279
Copy link
Contributor Author

vsky279 commented Feb 10, 2019

@nwf Up to you. I think the sooner it is corrected the better. It can be quite misleading when the shipped lua examples do not work.

@nwf
Copy link
Member

nwf commented Feb 10, 2019

@vsky279 Agreed re: timeline. Probably best to commit this one and let #2650 linger a little bit for review.

@marcelstoer
Copy link
Member

@vsky279 could you please address Nathaniel's review comments so we can merge this afterwards?

@marcelstoer marcelstoer changed the title Minor fix to telnet lua example and ftpserver lua module Minor fix to telnet Lua example and ftpserver Lua module Feb 12, 2019
@marcelstoer marcelstoer merged commit 27e9e6c into nodemcu:dev Feb 13, 2019
@vsky279 vsky279 deleted the telnet-ftp-fix branch March 3, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwf nwf nwf left review comments

@marcelstoer marcelstoer marcelstoer requested changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
Winter 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@vsky279 @nwf @marcelstoer